This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: FAIL: string/tst-strcoll-overflow
On 01/16/2017 09:24 AM, Stefan Liebler wrote:
On 01/13/2017 11:14 PM, H.J. Lu wrote:
On x86-64 with 32GB RAM under kernel 4.9.3, I got
string/tst-strcoll-overflow
0
Expected signal 'Alarm clock' from child, got none
Has anyone else seen this?
As information:
This test fails on s390 and a machine from Florian Weimer, too.
See "Re: [PATCH] support: Introduce new subdirectory for test
infrastructure"
https://sourceware.org/ml/libc-alpha/2016-12/msg00391.html and follow-Ups.
I came up with the attached patch to fix this test.
We could use file-based alias mappings to greatly reduce the amount of
memory required for this test, but this should probably wait until after
the release.
Thanks,
Florian
string/tst-strcoll-overflow: Do not accept timeout as test result
The test completes within 300 seconds if enough memory is available.
2017-01-23 Florian Weimer <fweimer@redhat.com>
* string/Makefile (xtests): Add comment.
(LOCALES): Add en_GB.UTF-8.
(tst-strcoll-overflow.out): Depend on generated locales.
* string/tst-strcoll-overflow.c: Convert to support/test-driver.c.
(SIZE, TIMEOUT): Update comments.
(do_test): Define as static. Fail test if setlocale fails.
Return EXIT_UNSUPPORTED if insufficient memory. Enhance output
messages.
(EXPECTED_SIGNAL, EXPECTED_STATUS, TEST_FUNCTION): Remove.
TIMEOUT at 300 seconds should be enough to run this test
successfully.
diff --git a/string/Makefile b/string/Makefile
index 901c4d4..f317d02 100644
--- a/string/Makefile
+++ b/string/Makefile
@@ -59,6 +59,7 @@ tests := tester inl-tester noinl-tester testcopy test-ffs \
tst-strtok_r bug-strcoll2 tst-cmp tst-xbzero-opt \
test-endian-types
+# This test allocates a lot of memory and can run for a long time.
xtests = tst-strcoll-overflow
ifeq ($(run-built-tests),yes)
@@ -94,7 +95,7 @@ $(objpfx)tst-svc-cmp.out: tst-svc.expect $(objpfx)tst-svc.out
LOCALES := de_DE.UTF-8 en_US.ISO-8859-1 en_US.UTF-8 \
tr_TR.ISO-8859-9 tr_TR.UTF-8 cs_CZ.UTF-8 \
- da_DK.ISO-8859-1
+ da_DK.ISO-8859-1 en_GB.UTF-8
include ../gen-locales.mk
$(objpfx)test-strcasecmp.out: $(gen-locales)
@@ -103,5 +104,6 @@ $(objpfx)tst-strxfrm.out: $(gen-locales)
$(objpfx)tst-strxfrm2.out: $(gen-locales)
# bug-strcoll2 needs cs_CZ.UTF-8 and da_DK.ISO-8859-1.
$(objpfx)bug-strcoll2.out: $(gen-locales)
+$(objpfx)tst-strcoll-overflow.out: $(gen-locales)
endif
diff --git a/string/tst-strcoll-overflow.c b/string/tst-strcoll-overflow.c
index ab76736..ee694b6 100644
--- a/string/tst-strcoll-overflow.c
+++ b/string/tst-strcoll-overflow.c
@@ -21,42 +21,34 @@
#include <stdlib.h>
#include <string.h>
-/* Verify that strcoll does not crash for large strings for which it cannot
- cache weight lookup results. The size is large enough to cause integer
- overflows on 32-bit as well as buffer overflows on 64-bit. The test should
- work reasonably reliably when overcommit is disabled, but it obviously
- depends on how much memory the system has. There's a limitation to this
- test in that it does not run to completion. Actually collating such a
- large string can take days and we can't have xcheck running that long. For
- that reason, we run the test for about 5 minutes and then assume that
- everything is fine if there are no crashes. */
+#include <support/check.h>
+#include <support/test-driver.h>
+
+/* Verify that strcoll does not crash for large strings for which it
+ cannot cache weight lookup results. The size is large enough to
+ cause integer overflows on 32-bit as well as buffer overflows on
+ 64-bit. */
#define SIZE 0x40000000ul
-int
+static int
do_test (void)
{
- if (setlocale (LC_COLLATE, "en_GB.UTF-8") == NULL)
- {
- puts ("setlocale failed, cannot test for overflow");
- return 0;
- }
+ TEST_VERIFY_EXIT (setlocale (LC_COLLATE, "en_GB.UTF-8") != NULL);
char *p = malloc (SIZE);
-
if (p == NULL)
{
- puts ("could not allocate memory");
- return 1;
+ puts ("info: could not allocate memory, cannot run test");
+ return EXIT_UNSUPPORTED;
}
memset (p, 'x', SIZE - 1);
p[SIZE - 1] = 0;
- printf ("%d\n", strcoll (p, p));
+ printf ("info: strcoll result: %d\n", strcoll (p, p));
return 0;
}
+/* This test can rung for a long time, but it should complete within
+ this time on reasonably current hardware. */
#define TIMEOUT 300
-#define EXPECTED_SIGNAL SIGALRM
-#define EXPECTED_STATUS 0
-#define TEST_FUNCTION do_test ()
-#include "../test-skeleton.c"
+#include <support/test-driver.c>