This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][AArch64] Add more cfi annotations to tlsdesc entry points
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Richard Henderson <rth at twiddle dot net>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: <nd at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Florian Weimer <fweimer at redhat dot com>
- Date: Mon, 23 Jan 2017 11:31:24 +0000
- Subject: Re: [PATCH v2][AArch64] Add more cfi annotations to tlsdesc entry points
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <584AB057.5050605@arm.com> <39560805-b142-5681-4f39-096bf7045e2a@twiddle.net> <584FEAE9.10207@arm.com> <586FBE78.8020901@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 06/01/17 15:57, Szabolcs Nagy wrote:
> On 13/12/16 12:34, Szabolcs Nagy wrote:
>> Backtrace through _dl_tlsdesc_resolve_rela was broken because the offset
>> of x30 from cfa was not in the debug info.
>>
>> Add enough annotation so backtracing from the dynamic linker through
>> tlsdesc entry points works and the debugger shows registers correctly.
>>
>> v2:
>> - group cfi_rel_offset annotations for smaller debug info.
>>
>> 2016-12-13 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>
>> * sysdeps/aarch64/dl-tlsdesc.S (_dl_tlsdesc_dynamic): Add cfi
>> annotation.
>> (_dl_tlsdesc_resolve_rela, _dl_tlsdesc_resolve_hold): Likewise.
>>
>
> ping.
>
ping.
this is a bug fix which should go in 2.25 i think.
(e.g. the elf/tst-tls-manydynamic crash is hard to debug without this).