This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Rename strdup uses

From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
Date: Thu, 12 Jan 2017 15:16:27 +0000
Subject: Re: [PATCH] Rename strdup uses
Authentication-results: sourceware.org; auth=none
Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco dot Dijkstra at arm dot com;
Nodisclaimer: True
References: <AM5PR0802MB2610773CACA9C6A1A84A44F583660@AM5PR0802MB2610.eurprd08.prod.outlook.com>,<alpine.DEB.2.20.1701111722580.6002@digraph.polyomino.org.uk>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

Joseph Myers wrote:
> On Wed, 11 Jan 2017, Wilco Dijkstra wrote:
>
> > Rename existing uses of str(n)dup to __str(n)dup so it no longer needs 
> > to be redirected to a builtin.  Also building GLIBC with -Os now no 
> > longer shows localplt or linkname space failures.  Although this means a 
>
> If this fixes such failures then [BZ #15105] and [BZ #19463] should be 
> included in the ChangeLog entry (if it fixes *all* such failures, then 
> additionally the bugs would be resolved as FIXED with milestone set once 
> this is in).

Yes it fixes a few of those failures, but there are plenty left. I think most are due
to disabling inlines with -Os (rather than using __extern_always_inline).
The question is it worth trying to fix these too?

Wilco

Follow-Ups:
- Re: [PATCH] Rename strdup uses
  - From: Joseph Myers

References:
- [PATCH] Rename strdup uses
  - From: Wilco Dijkstra
- Re: [PATCH] Rename strdup uses
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]