Re: [PATCH 2/4] Initialize tunable list with the GLIBC_TUNABLES environment variable

[Florian Weimer <fweimer at redhat dot com>]

On 12/31/2016 04:40 PM, Siddhesh Poyarekar wrote:
> +  while (in[i++]);
> +  char *out = __sbrk (i);

This still has an implicit comparision against '\0', which is against 
the style guide.

> +  /* FIXME: In reality this will not return NULL, it will crash attempting to
> +     set the thread-local errno since the TCB has not yet been set up.  This
> +     needs to be fixed with an __sbrk implementation that does not set
> +     errno.  */
> +  if (out == (void *)-1)
> +    return NULL;

Comment does not match: NULL is not (void *) -1.

Thanks,
Florian