This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4] Add cancellation regression test for getpwuid_r.


On 12/21/2016 08:08 AM, Florian Weimer wrote:
> On 12/20/2016 09:44 PM, Carlos O'Donell wrote:
>> +  printf( "INFO: Joining...\n");
>> +  pthread_join(thread, &retval);
> 
> Please fix the GNU style violations before committing.

Thanks, I fixed six instances of GNU style violations and committed the
new regression test.

commit b0a679f4fd5363809a972b697e8a0b1fc66fcbb1
Author: Carlos O'Donell <carlos@redhat.com>
Date:   Fri Dec 23 13:39:23 2016 -0500

    Add deferred cancellation regression test for getpwuid_r.
    
    The fix in commit 312be3f9f5eab1643d7dcc7728c76d413d4f2640 resolved
    several cancellation issues in several APIs.  This regression test is
    designed to double check that at least getpwuid_r remainds correctly
    implemented and does not provide additional unintended cancellation
    points that may leave locks in an inconsistent state.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]