This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 05/16] Improve generic memchr
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Richard Henderson <rth at twiddle dot net>, libc-alpha at sourceware dot org
- Cc:
- Date: Fri, 23 Dec 2016 16:33:29 -0200
- Subject: Re: [PATCH v2 05/16] Improve generic memchr
- Authentication-results: sourceware.org; auth=none
- References: <20161221230605.28638-1-rth@twiddle.net> <20161221230605.28638-6-rth@twiddle.net>
Richard Henderson <rth@twiddle.net> writes:
> -#ifdef weak_alias
> +
> +#ifndef MEMCHR
> weak_alias (__memchr, memchr)
> -#endif
> libc_hidden_builtin_def (memchr)
> +#endif
If you make this change, you also have to make the following change.
LGTM with it.
diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c b/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c
index 9861337..6faf996 100644
--- a/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c
+++ b/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c
@@ -23,12 +23,10 @@
#undef weak_alias
#define weak_alias(a, b)
-#ifdef SHARED
-# undef libc_hidden_builtin_def
-# define libc_hidden_builtin_def(name) \
- __hidden_ver1(__memchr_ppc, __GI_memchr, __memchr_ppc);
-#endif
-
extern __typeof (memchr) __memchr_ppc attribute_hidden;
#include <string/memchr.c>
+
+#ifdef SHARED
+__hidden_ver1(__memchr_ppc, __GI_memchr, __memchr_ppc);
+#endif
--
Tulio Magno