This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Bug 11941: Improper assert map->l_init_called in dlclose

On 12/22/2016 09:47 PM, Carlos O'Donell wrote:


s/plugin/plugin_func/g.


GNU does not use “()” to mark function names:

+   destructed we will be calling dlclose() on an object that has already
+   been destructed.  It is allowed to call dlclose() in this way and
+     hasn't called primary(), in that case do nothing.  */
There is still a missing space before the parameter list in a function pointer type: 

+  plugin_func = (void (*)(void)) dlsym (plugin_lib, "plugin_func");

Okay with these changes.

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]