This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ #20985] robust mutexes: Fix broken x86 assembly by removing it
- From: Torvald Riegel <triegel at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, "Carlos O'Donell" <codonell at redhat dot com>
- Date: Thu, 22 Dec 2016 12:23:18 +0100
- Subject: Re: [PATCH] [BZ #20985] robust mutexes: Fix broken x86 assembly by removing it
- Authentication-results: sourceware.org; auth=none
- References: <1482402167.14990.784.camel@redhat.com> <a9cb13a5-5041-bf88-fd86-20dcc8a8a896@redhat.com>
On Thu, 2016-12-22 at 12:06 +0100, Florian Weimer wrote:
> On 12/22/2016 11:22 AM, Torvald Riegel wrote:
> > (LLL_ROBUST_MUTEX_LOCK_MODIFIER): New.
>
> This needs to be documented in the code. It seems the code always
> defines it as 0, so it's not clear to me why it makes sense to define it
> at all (twice even).
This should be defined differently when pthread_mutex_cond_lock.c
includes the file; I just noticed that it doesn't do that.
Is the patch OK besides that (ie, so after fixing that oversight and
adding a suitable comment to the definition of
LLL_ROBUST_MUTEX_LOCK_MODIFIER?).
> I think this patch addresses part of bug 20965 as well.
Yes.