This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] localedata: bs_BA: fix yesexpr/noexpr [BZ #20974]
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Fri, 16 Dec 2016 22:24:01 +0100 (CET)
- Subject: Re: [PATCH] localedata: bs_BA: fix yesexpr/noexpr [BZ #20974]
- Authentication-results: sourceware.org; auth=none
- References: <20161215233558.9658-1-vapier@gentoo.org> <20161216180911.GD10558@vapier.lan>
- Reply-to: Rafal Luzynski <digitalfreak at lingonborough dot com>
Mike,
16.12.2016 19:09 Mike Frysinger <vapier@gentoo.org> wrote:
>
>
> On 15 Dec 2016 18:35, Mike Frysinger wrote:
> > Both regexes end with a "*." which means the previous match can be
> > omitted, and then the . allows them to match any input at all.
> >
> > This means tools like coreutils' `rm -i` will always delete things
> > when prompted because the yesexpr regex matches all inputs (even
> > the negative ones).
>
> meant to include this, but here's the diff made readable:
> -yesexpr "^[+1dDyY]*."
> -noexpr "^[-0nN]*."
> +yesexpr "^[+1dDyY]"
> +noexpr "^[-0nN]"
> -mike
I guess the original author's intention was to put ".*" at the end
instead of "*." so first I was thinking about changing it into ".*".
But now I see you have removed all trailing ".*" from all locales.
If it works this way then I dare to say LGTM.
You may want to hear opinion from other people.
Regards,
Rafal