This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nptl: Avoid expected SIGALRM in most tests [BZ #20432]


On 12/15/2016 04:55 PM, Andreas Schwab wrote:
On Aug 17 2016, fweimer@redhat.com (Florian Weimer) wrote:

diff --git a/nptl/tst-stdio1.c b/nptl/tst-stdio1.c
index 2d44c16..4250e53 100644
--- a/nptl/tst-stdio1.c
+++ b/nptl/tst-stdio1.c
@@ -21,6 +21,10 @@
 #include <stdio.h>
 #include <unistd.h>

+static int do_test (void);
+
+#define TEST_FUNCTION do_test ()
+#include "../test-skeleton.c"

 static void *tf (void *a)
 {
@@ -43,14 +47,10 @@ do_test (void)
       _exit (1);
     }

-  pthread_join (th, NULL);
+  delayed_exit (1);
+  xpthread_join (th);

   puts ("join returned");

-  return 0;
+  return 1;
 }
-
-
-#define EXPECTED_SIGNAL SIGALRM
-#define TEST_FUNCTION do_test ()
-#include "../test-skeleton.c"

That doesn't work, the test now always times out because exit blocks on
flockfile.

The test previously called exit from the signal handler. Why did it work before?

And I don't see this blocking behavior.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]