This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 03/12] Mark all machinery needed in early static-link init as -fno-stack-protector.

From: Florian Weimer <fweimer at redhat dot com>
To: Nix <nix at esperi dot org dot uk>, libc-alpha at sourceware dot org
Cc: Nick Alcock <nick dot alcock at oracle dot com>
Date: Thu, 15 Dec 2016 15:01:41 +0100
Subject: Re: [PATCH 03/12] Mark all machinery needed in early static-link init as -fno-stack-protector.
Authentication-results: sourceware.org; auth=none
References: <20161128123228.30856-1-nix@esperi.org.uk> <20161128123228.30856-4-nix@esperi.org.uk>

On 11/28/2016 01:32 PM, Nix wrote:

diff --git a/csu/Makefile b/csu/Makefile
index 31e8bb9..22afe67 100644
--- a/csu/Makefile
+++ b/csu/Makefile
@@ -45,6 +45,11 @@ before-compile += $(objpfx)version-info.h
 tests := tst-empty tst-atomic tst-atomic-long
 tests-static := tst-empty

+CFLAGS-.o += $(no-stack-protector)

This also applies to the tests in the csu subdirectory, which isprobably not what we want.

We have two options here: List the .c source files explicitly (like youdo in string/), or move the test to a different subdirectory (perhapsmisc/ or stdlib/). In the second case, there should be an empty “tests”variable assignment in csu/Makefile which documents why there can't beany tests in this subdirectory.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH 03/12] Mark all machinery needed in early static-link init as -fno-stack-protector.
  - From: Nick Alcock

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]