This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [GLIBC][PATCH] Remove strcmp inlines
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>, Joseph Myers <joseph at codesourcery dot com>
- Cc: Zack Weinberg <zackw at panix dot com>, nd <nd at arm dot com>, "adhemerval dot zanella at linaro dot org" <adhemerval dot zanella at linaro dot org>
- Date: Wed, 14 Dec 2016 14:35:35 +0000
- Subject: Re: [GLIBC][PATCH] Remove strcmp inlines
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco dot Dijkstra at arm dot com;
- Nodisclaimer: True
- References: <AM5PR0802MB2610A1F99165A04F1C48645283980@AM5PR0802MB2610.eurprd08.prod.outlook.com>,<CAKCAbMjq5ejLcCy0NuEyGTsmqVrHECZXAEs-TgLwK6XqSmzDLQ@mail.gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Joseph wrote:
On Mon, 12 Dec 2016, Adhemerval Zanella wrote:
> > I tend to agree with your rationale, however tying remove existing
> > string2.h microoptimization with compiler support one can argue that
> > we still need to support old compiler and then it will require multiple
> > releases to actually remove such code.
>
> Well, considering the GNU system as a whole a minimum if the optimization
> is plausibly useful would be at least to make sure there is a GCC bug
> filed for it before removing the optimization from glibc.
Yes I agree this is a reasonble optimization, so I've created PR 78809.
It probably doesn't help a lot in general code but the current optimizations
on strcmp are basic and that only deal with both strings constant or one
string being the empty string.
Wilco