This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Enable ILP32 mode on aarch64 (version 2)
On Dez 07 2016, Steve Ellcey <sellcey@caviumnetworks.com> wrote:
> On Wed, 2016-12-07 at 12:52 +0100, Andreas Schwab wrote:
>
>> >
>> > +#define STATFS_IS_STATFS64 1
>> This is a lie. You are using .../generic/bits/statfs.h, which assumes
>> that fsblkcnt64_t == 2* fsblkcnt_t (etc.), but ILP32 wants them to be
>> the same.
>
> So it looks like there are two choices, change STATFS_IS_STATFS64 to
> __STATFS_IS_STATFS64 so that I can use it to
> ifdef generic/bits/statfs.h without polluting the namespace or
> introduce a new aarch64/bits/statfs.h header to use instead of
> generic/bits/statfs.h. Is there a preference one way or the other?
> My inclination is to create a new header file.
I agree. The X_IS_Y defines should be kept internal.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."