This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] extras: New test/build infrastructure
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 25 Nov 2016 17:29:24 +0000
- Subject: Re: [PATCH] extras: New test/build infrastructure
- Authentication-results: sourceware.org; auth=none
- References: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com>
On Fri, 25 Nov 2016, Florian Weimer wrote:
> I do not propose bulk migration at this point. Some obscure use cases are not
> supported by the exported hooks.
I agree with the other comments about naming this something like
libtest-support.a (and naming headers, directories accordingly).
I think there would be clear advantages to setting things up so that all
existing tests can use the new code with no changes at all. That is, make
test-skeleton.c look more or less like your extras/test-skeleton.c, with
additional code to handle any missing pieces (e.g.
int
test_function (int argc, char **argv)
{
return TEST_FUNCTION;
}
to handle existing TEST_FUNCTION definitions without needing changes to
individual tests). If a slightly different interface is preferred, then
individual tests could be converted to that afterwards.
--
Joseph S. Myers
joseph@codesourcery.com