This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Test case for BZ 19329


On 11/24/2016 01:31 PM, Szabolcs Nagy wrote:

Please do not use assert in tests.  Use the xpthread_* functions in test-skeleton.c instead.


i can do that but it looks ugly.

Well.  The asserts are incorrect because you rely on their side effects.

This test will fail on large SMP machines due to timeouts because thread creation is rather expensive there.  A
less resource-intense way of writing this test would be to iterate multiple times and try to hit the race each
time, with a smaller number of threads created in parallel.


i can try, but iterating is not easy: there
is dynamic linker internal state that cannot
be reset (generation counter, max dtv idx,
allocated slotininfo entries) so i'd need to
start a new process for every iteration.

Can you use fork before each round?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]