This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allow [f]statfs64 to alias [f]statfs
On Wed, 2016-11-23 at 00:01 +0000, Joseph Myers wrote:
> I'm seeing a build failure for alpha with build-many-glibcs.py that
> seems
> likely related to this change:
>
> /scratch/jmyers/glibc/many6/build/glibcs/alpha-linux-
> gnu/glibc/libc_pic.os: In function `__statfs64':
> /scratch/jmyers/glibc/many6/build/glibcs/alpha-linux-gnu/glibc-
> src/io/../sysdeps/unix/sysv/linux/statfs64.c:65: undefined reference
> to `__GI___statfs_disable'
> /scratch/jmyers/glibc/many6/build/glibcs/alpha-linux-
> gnu/glibc/libc_pic.os: In function `__fstatfs64':
> /scratch/jmyers/glibc/many6/build/glibcs/alpha-linux-gnu/glibc-
> src/io/../sysdeps/unix/sysv/linux/fstatfs64.c:63: undefined reference
> to `__fstatfs_disable'
> /scratch/jmyers/glibc/many6/build/glibcs/alpha-linux-gnu/glibc-
> src/io/../sysdeps/unix/sysv/linux/fstatfs64.c:63: undefined reference
> to `__fstatfs_disable'
> collect2: error: ld returned 1 exit status
> ../Makerules:703: recipe for target
> '/scratch/jmyers/glibc/many6/build/glibcs/alpha-linux-
> gnu/glibc/libc.so' failed
Yes, this is due to my patch. I have reproduced the problem and am
working on a patch. I failed to notice that on alpha, the only
platform where __ASSUME_STATFS64 is 0, __statfs64 will call __statfs
and if we have renamed __statfs with a define to __statfs_disable then
it breaks. I am looking at putting the define under '#if
STATFS_IS_STATFS64', but I can't do that until after I have included
kernel_stat.h and I have to do it before including sys/stat.h for the
define to have any effect. Hopefully that will fix things, but I am
still testing.
Steve Ellcey
sellcey@caviumnetworks.com