This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Allow [f]statfs64 to alias [f]statfs


On Thu, 2016-11-17 at 09:53 +0100, Andreas Schwab wrote:
> On Nov 07 2016, Steve Ellcey <sellcey@cavium.com> wrote:
> 
> > 
> > My main question is, is this an OK use of '#ifdef' or should the
> > STATFS_IS_STATFS64 be defined on all platforms (presumably in
> > kernel_stat.h)
> > so that we can check the value instead of checking to see it is
> > defined
> > or not?
> Since it is a new symbol it should follow the policy of always being
> defined.

OK, but since having STATFS_IS_STATFS64 be handled one way
and XSTAT_IS_XSTAT64 handled a different way bothers my sense of
consistency I am going to first submit a patch to always define
XSTAT_IS_XSTAT64, then redo this patch.  Hopefully a patch to always
define XSTAT_IS_XSTAT64 will be acceptable (after testing, etc).

Steve Ellcey
sellcey@caviumnetworks.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]