This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v7] getrandom system call wrapper [BZ #17252]
- From: Zack Weinberg <zackw at panix dot com>
- To: libc-alpha at sourceware dot org
- Date: Mon, 14 Nov 2016 13:29:40 -0500
- Subject: Re: [PATCH v7] getrandom system call wrapper [BZ #17252]
- Authentication-results: sourceware.org; auth=none
- References: <3dd5d3b8-c196-98fb-1671-90cd90ab90c7@redhat.com>
On 11/14/2016 12:44 PM, Florian Weimer wrote:
> This patch switches back to the ssize_t return time. This goes against
> Theodore Ts'o preference, but seems to reflect the consensus from the
> largery community.
I still don't think this function should be a cancellation point.
> I weakened the protection against accidental interposition somewhat.
> Since the declaration is a new header file, I do not use a function-like
> macro to prevent a definition of a function named “getrandom”, and
> non-GNU compilers do not get any redirection.
We don't normally do this at all. I don't understand why this function
should be treated differently. Can you please explain what concrete
situations, involving real, existing code, you're trying to defend
against here?
zw