This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 0/2] Cleanup some calls to write with unused result


While working on https://sourceware.org/ml/libc-alpha/2016-10/msg00535.html, I
became aware of write_message.  This patch is a similar cleanup for other parts
of the code.

The first patch only replaces calls to write on stdout,  whereas the second
also adds a new function which writes to stderr, instead of stdout.

Is this a good cleanup?

Tested for powerpc64le.

Gabriel F. T. Gomes (2):
  Use write_message instead of write
  Add write_message_to_stderr and use it instead of write

 nptl/tst-basic1.c   | 15 ++++++++-------
 nptl/tst-cleanup1.c | 11 ++++++-----
 nptl/tst-cleanup3.c | 11 ++++++-----
 nptl/tst-key1.c     | 11 ++++++-----
 nptl/tst-key2.c     | 23 ++++++++++++-----------
 nptl/tst-key3.c     | 31 ++++++++++++++++---------------
 nptl/tst-kill3.c    | 13 +++++++------
 nptl/tst-kill6.c    | 15 ++++++++-------
 nptl/tst-stdio1.c   |  2 +-
 nptl/tst-stdio2.c   | 11 ++++++-----
 nptl/tst-tls2.c     | 15 ++++++++-------
 nptl/tst-tls3.c     | 13 +++++++------
 test-skeleton.c     |  9 +++++++++
 13 files changed, 100 insertions(+), 80 deletions(-)

-- 
2.4.11


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]