This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add test for linking against most static libraries
On 10/28/2016 01:29 PM, Carlos O'Donell wrote:
> On 10/28/2016 10:51 AM, Carlos O'Donell wrote:
>> On 10/28/2016 08:57 AM, Florian Weimer wrote:
>>> 2016-10-28 Florian Weimer <fweimer@redhat.com>
>>>
>>> * elf/tst-linkall-static.c: New file.
>>> * elf/Makefile (tests-static): Add tst-linkall-static.
>>> (tst-linkall-static): Link against static libraries.
>>
>> LGTM. Thanks for increasing test coverage.
>>
>
> This breaks my i486 -Os build with a test build failures because
> it can't find crypt.h.
>
> I don't see that any of the sysdep selection mechanisms add
> crypt to the list, therefore you can't access crypt headers.
>
> However, the crypt/ tests themselves seem to get an absolute
> path added explicitly, so they work.
>
> The only other reference is from locale/Makefile which also
> adds -I../crypt via vpath and CFLAGS-*.
>
> I'm kinda baffled by this. We don't set it in config-sysdirs.
>
> I expect you have a local patch that hid this.
>
> I'm going to commit the following immediate fix:
>
> 2016-10-28 Carlos O'Donell <carlos@redhat.com>
>
> * elf/Makefile (CFALGS-tst-linkall-static): Define.
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 82c7e05..a8d2bfe 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -1280,6 +1280,7 @@ $(objpfx)tst-ldconfig-X.out : tst-ldconfig-X.sh $(objpfx)ldconfig
>
> $(objpfx)tst-dlsym-error: $(libdl)
>
> +CFLAGS-tst-linkall-static = -I../crypt
> $(objpfx)tst-linkall-static: \
> $(common-objpfx)math/libm.a \
> $(common-objpfx)crypt/libcrypt.a \
> ---
Without the typo (missing '.c' in CFLAGS rule).
--
Cheers,
Carlos.