This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v7 3/3] Add tests for strfrom functions

On Thu, 6 Oct 2016, Gabriel F. T. Gomes wrote:

> +  double val;

I'd expect the tables of data to be included in the type-generic parts of 
the tests rather than always using double in those tables.  For example:

> +  {"NAN", __builtin_nans (""), "%G", 50, 3},

Testing sNaNs won't have the intended effect if there's a conversion from 
double to another type involved.

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]