This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] hppa: Optimize atomic_compare_and_exchange_val_acq

From: Florian Weimer <fw at deneb dot enyo dot de>
To: John David Anglin <dave dot anglin at bell dot net>
Cc: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, deller at kernel dot org, Mike Frysinger <vapier at gentoo dot org>, Aurelien Jarno <aurelien at aurel32 dot net>
Date: Fri, 23 Sep 2016 09:13:05 +0200
Subject: Re: [PATCH] hppa: Optimize atomic_compare_and_exchange_val_acq
Authentication-results: sourceware.org; auth=none
References: <58B70052-B987-4C41-B603-F3AAB2FDE34B@bell.net> <85e42696-2979-c359-ac83-b6cc6a34bb67@redhat.com> <CA5F11AD-A3C1-4037-BDC1-31025BDAFEF4@bell.net>

* John David Anglin:

>>> The change was intended as an optimization but tst-stack4 now passes.
>> 
>> This is a red flag for this patch.
>
> The patch has had a significant amount of testing and I'm sure there
> are no functional issues.  It is important to simplify
> when possible.
>
> Why red flag an improvement in test results?

I share Carlos' concern.  If this patch appears to fix tst-stack4,
then it has unforeseen consequences.  We just don't understand the
full impact of this change.

Follow-Ups:
- Re: [PATCH] hppa: Optimize atomic_compare_and_exchange_val_acq
  - From: Carlos O'Donell

References:
- [PATCH] hppa: Optimize atomic_compare_and_exchange_val_acq
  - From: John David Anglin
- Re: [PATCH] hppa: Optimize atomic_compare_and_exchange_val_acq
  - From: Carlos O'Donell
- Re: [PATCH] hppa: Optimize atomic_compare_and_exchange_val_acq
  - From: John David Anglin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]