This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add test case for O_TMPFILE handling in open, openat


On 09/20/2016 09:26 PM, Carlos O'Donell wrote:
On 09/20/2016 02:51 PM, Florian Weimer wrote:
I noticed that we do not seem to have a test case for O_TMPFILE
handling.

I have tested the attached patch with recent kernels and Red Hat's
3.10 kernels (where it prints UNSUPPORTED).  I verified that
probe_path works as intended with a vfat file system (which does not
support O_TMPFILE even on a supported kernel).

The actual details of the patch look good to me, so OK conditional
on more comments about:
* What is being tested.
* Is it sufficient?
  * If not, where might we improve in the future?
* Under what conditions do we mark as UNSUPPORTED?

I tried to add a test for linkat, but it appears to be broken at the kernel level:

  <http://marc.info/?l=linux-man&m=147445864822403&w=2>

I'll probably commit the glibc test without the linkat bits.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]