This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] posix: Correctly block/unblock all signals on Linux posix_spawn

From: Florian Weimer <fw at deneb dot enyo dot de>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Tue, 20 Sep 2016 22:03:52 +0200
Subject: Re: [PATCH 2/2] posix: Correctly block/unblock all signals on Linux posix_spawn
Authentication-results: sourceware.org; auth=none
References: <1473879370-6731-1-git-send-email-adhemerval.zanella@linaro.org> <1473879370-6731-2-git-send-email-adhemerval.zanella@linaro.org>

* Adhemerval Zanella:

> This patch correctly block and unblocks all signals when executing
> Linux posix_spawn by using the __libc_signal_{un}block_all functions
> instead of default sigprocmask.  The latter might remove both
> SIGCANCEL and SIGSETXID from the blocked signal list.
>
> Checked on x86_64, i686, powerpc64le, and aarch64.
>
> 	* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Correctly block and unblock
> 	all signals when executing the clone vfork child.
> 	(SIGALL_SET): Remove macro.

Looks good to me.  Thanks.

References:
- [PATCH 1/2] posix: Correctly enable/disable cancellation on Linux posix_spawn
  - From: Adhemerval Zanella
- [PATCH 2/2] posix: Correctly block/unblock all signals on Linux posix_spawn
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]