This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove the ptw-% patterns


On 09/14/2016 10:12 AM, Florian Weimer wrote:
> On 09/13/2016 07:19 PM, Andreas Schwab wrote:
>> If that doesn't create any problems due to the duplicated module
>> names then this is ok.
> 
> We already duplicate sigaction (and likely others) in this way, so I
> don't expect any problems.  I also checked libpthread.a and
> libpthread.so before and after this change using “objdump -d”, and
> there are no changes in the disassembly.  Committed.

I'm happy to see us cut down on the number of auto-generated rules.

I think that if you can show no difference before an after on the generated
binary, that is should be an easy matter to just commit the changes. Since
these changes are usually generic. A quick grep might show any arch-specific
uses of some rules.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]