This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv4 4/8] Convert _Complex sine functions to generated code

On Thu, 18 Aug 2016, Paul E. Murphy wrote:

> +	      __real__ res = M_LOG1P (rx2 + dm + 2
> +				      * (rx * r1 + ix * r2)) / 2;

I don't like this choice of position for a line break, since the '*' at 
the start of the second line only applies to the 2 on the line above, not 
to the whole of "rx2 + dm + 2" which the split makes it look like it 
should apply to.

Patches 3 and 4 are OK with that fixed (for example, to have the second 
line start "+ 2 * (rx...").  The same comments as before apply about scope 
for m68k maintainers to make further cleanups.

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]