This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2 3/5] ldbl-128: Rename 'long double' to '_Float128'


On Thu, 18 Aug 2016 14:42:30 -0500
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> wrote:

> Add a layer of macro indirection for long double files
> which need to be built using another typename.  Likewise,
> add the L(num) macro used in a later patch to override
> real constants.
> 
> These macros are only defined through the ldbl-128
> math_ldbl.h header, thereby implicitly restricting
> these macros to machines which back long double
> with an IEEE binary128 format.
> 
> Likewise, appropriate changes are made for the few
> files which indirectly include such ldbl-128 files.
> 
> These changes produce identical binaries for s390x,
> aarch64, and ppc64.
> 
> 	* sysdeps/ieee754/ldbl-128/math_ldbl.h:
> 	[!defined (FLT128_MANT_DIG)] (_Float128): Define as long double
> 	for compilers which do not support this type.
> 
> 	(L): New macro to append the correct type-suffix depending
> 	on whether _Float128 is a macro redirection to long double.
> 
> 	* sysdeps/ieee754/ldbl-128/e_acoshl.c: Rename long double
> 	ldouble_t and ensure math_private.h gets added as needed.

I think this comment needs to be update to reflect this new version of
the patch.

otherwise, lgtm.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]