This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64

From: Florian Weimer <fweimer at redhat dot com>
To: Jeff Layton <jlayton at redhat dot com>, libc-alpha at sourceware dot org
Cc: linux-fsdevel at vger dot kernel dot org, Michael Kerrisk <mtk dot manpages at gmail dot com>, "Carlos O'Donell" <carlos at redhat dot com>, Yuriy Kolerov <Yuriy dot Kolerov at synopsys dot com>
Date: Wed, 17 Aug 2016 19:34:35 +0200
Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64
Authentication-results: sourceware.org; auth=none
References: <1471445251-2450-1-git-send-email-jlayton@redhat.com>

On 08/17/2016 04:47 PM, Jeff Layton wrote:

The Linux kernel expects a flock64 structure whenever you use OFD locks
with fcntl64. Unfortunately, you can currently build a 32-bit program
that passes in a struct flock when it calls fcntl64.

Only define the F_OFD_* constants when __USE_FILE_OFFSET64 is also
defined, so that the build fails in this situation rather than
producing a broken binary.

Doesn't this affect legacy POSIX-style locks as well, under very similarcircumstances?


Thanks,
Florian

Follow-Ups:
- Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64
  - From: Jeff Layton

References:
- [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64
  - From: Jeff Layton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]