This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Mon, 15 Aug 2016 00:06:40 -0700
Subject: Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
Authentication-results: sourceware.org; auth=none
References: <20160814190124.C1152403B91DC@oldenburg.str.redhat.com> <1cbcbd70-c399-7348-a15c-261180c2070c@cs.ucla.edu> <ec5bff13-c577-6688-e79a-13d0dfc23a4f@redhat.com>

Florian Weimer wrote:

#ifndef _GL_INLINE_HEADER_BEGIN
 #error "Please include config.h first."
#endif

This will result in an #error if the installed header <argp.h> is used by
applications.

Then let's remove those three lines. They are not essential for Gnulib, andstaying in sync with glibc is more important than the extra error-checking theymight provide for Gnulib users.

Follow-Ups:
- Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
  - From: Florian Weimer

References:
- [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
  - From: Florian Weimer
- Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
  - From: Paul Eggert
- Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]