This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [01/12] Add fesetexcept

From: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org, marcus dot shawcroft at arm dot com, rth at redhat dot com, carlos at redhat dot com, vapier at gentoo dot org, schwab at suse dot de, stli at linux dot vnet dot ibm dot com, davem at davemloft dot net
Date: Fri, 12 Aug 2016 12:25:15 -0500
Subject: Re: [01/12] Add fesetexcept
Authentication-results: sourceware.org; auth=none
References: <alpine.DEB.2.20.1608112053120.1591@digraph.polyomino.org.uk> <0f1ecdf3-4b8d-14a2-4fcf-3fc575948355@linux.vnet.ibm.com> <alpine.DEB.2.20.1608121615330.17306@digraph.polyomino.org.uk>


On 08/12/2016 11:20 AM, Joseph Myers wrote:
> On Fri, 12 Aug 2016, Paul E. Murphy wrote:
> 
>>> +  /* The test is that this does not cause exception traps.  */
>>
>> This is the test description.  It would improve readability by reworking
>> it into the file description at the top.
> 
> This comment is specifically intended to relate to the following line of 
> code (to explain why nothing is checked about exception flags after that 
> call, for example).  I don't think moving that information away from the 
> potentially trapping function call would be an improvement.


At least, please simplify the comment. e.g

/* Verify fesetexcept does not cause exception traps.  */

reads better.

Follow-Ups:
- Re: [01/12] Add fesetexcept
  - From: Joseph Myers

References:
- [01/12] Add fesetexcept
  - From: Joseph Myers
- Re: [01/12] Add fesetexcept
  - From: Paul E. Murphy
- Re: [01/12] Add fesetexcept
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]