This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH v9] Add pretty printers for the NPTL lock types


On Tue, Jul 12, 2016 at 4:52 AM, Stefan Liebler <stli@linux.vnet.ibm.com> wrote:
> I've tested it on a fedora 23 i686 vm with the following packages:
> -python2-pexpect-4.0.1-4.fc23.noarch
> -gdb-7.10-23.fc23.i686
>
> As mentioned by Siddhesh the ~/.gdbinit contains:
> python
> import sys
> sys.path.insert(0, '/home/stli/glibcDir/glibc-20160712_pp-build/nptl/')
> end
>
> source /home/stli/glibcDir/glibc/nptl/nptl-printers.py
> add-auto-load-safe-path /home/stli/glibcDir/glibc-20160712_pp-build/nptl_db

Odd. I've tested it with older and newer versions of gdb; will give it
a shot with that exact version to see if it's a gdb bug or something.

On Tue, Jul 12, 2016 at 5:35 AM, Siddhesh Poyarekar
<siddhesh@sourceware.org> wrote:
> So lets do this:
>
> 1. Dump the separate directory idea since that's getting too
>    convoluted
>
> 2. Put the tests in nptl.
>
> 3. Move test_common.py into scripts and call it "pp_test_common.py".
>
> 4. Move README to toplevel README.pretty-printers
>
> If we ever end up with a significant set of common files for the
> pretty printers then we can justify having a separate directory for
> them.  I hope this will make things much more straightforward and also
> consistent with everything else in glibc.

Yay for backtracking. I'm concerned about how would we change a
module's Makefile when we add pretty printers to it.
tests-need-hardcoded-path would now affect the entire module's tests,
not just the printer ones, and the rule for testing the printers would
have to be replicated for each module that has them.

Besides that, now I have the problem of the tests having to somehow
find pp_test_common.py, though I could solve that by adding scripts/
to PYTHONPATH before invoking the tests.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]