This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Compile tst-cleanupx4 test with -fexceptions
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 30 Jun 2016 12:42:43 +0200
- Subject: Re: [PATCH] Compile tst-cleanupx4 test with -fexceptions
- Authentication-results: sourceware.org; auth=none
- References: <20160601211705 dot GA29115 at intel dot com>
On 2016-06-01 14:17, H.J. Lu wrote:
> tst-cleanupx4 is linked with tst-cleanupx4.o and tst-cleanup4aux.o.
> Since tst-cleanupx4.o is compiled from tst-cleanup4.c with -fexceptions,
> tst-cleanupx4.c should also be compiled with -fexceptions.
>
> Tested on x86-64 and i686. OK for master?
>
>
> H.J.
> --
> [BZ 18645]
> * nptl/Makefile (extra-test-objs): Add tst-cleanupx4aux.o
> (test-extras): Add tst-cleanupx4aux.
> (CFLAGS-tst-cleanupx4aux.c): New. Set to -fexceptions.
> ($(objpfx)tst-cleanupx4): Replace tst-cleanup4aux.o with
> tst-cleanupx4aux.o.
> * nptl/tst-cleanupx4aux.c: New file.
> ---
> nptl/Makefile | 8 +++++---
> nptl/tst-cleanupx4aux.c | 1 +
> 2 files changed, 6 insertions(+), 3 deletions(-)
> create mode 100644 nptl/tst-cleanupx4aux.c
I am probably a bit late, but I have been pointed in the past there that
the point of tst-cleanupx4 is actually to test unwinding through a
function not compliled with -fexceptions:
https://sourceware.org/ml/libc-alpha/2014-07/msg00299.html
Note that I have identified the GCC change which introduced this
regression:
http://www.sourceware.org/ml/libc-alpha/2015-11/msg00533.html
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net