This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Compile tst-cleanupx4 test with -fexceptions

From: Mike Frysinger <vapier at gentoo dot org>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 29 Jun 2016 21:25:22 -0400
Subject: Re: [PATCH] Compile tst-cleanupx4 test with -fexceptions
Authentication-results: sourceware.org; auth=none
References: <20160601211705 dot GA29115 at intel dot com>

On 01 Jun 2016 14:17, H.J. Lu wrote:
> tst-cleanupx4 is linked with tst-cleanupx4.o and tst-cleanup4aux.o.
> Since tst-cleanupx4.o is compiled from tst-cleanup4.c with -fexceptions,
> tst-cleanupx4.c should also be compiled with -fexceptions.

i think this last line you meant "tst-cleanupx4aux.c", or at least
generalize it to say "the aux object".

> Tested on x86-64 and i686.  OK for master?
> 
> 
> H.J.
> --
> 	[BZ 18645]

need a # before the bug number

> 	* nptl/Makefile (extra-test-objs): Add tst-cleanupx4aux.o

period at the end

nits aside, patch looks OK
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] Compile tst-cleanupx4 test with -fexceptions
  - From: H.J. Lu

References:
- [PATCH] Compile tst-cleanupx4 test with -fexceptions
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]