This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S390: Fix relocation of _nl_current_LC_CATETORY_used in static build. [BZ #19860]


On 06/28/2016 12:13 PM, Andreas Schwab wrote:
Stefan Liebler <stli@linux.vnet.ibm.com> writes:

diff --git a/locale/localeinfo.h b/locale/localeinfo.h
index 94627f3..d3e575f 100644
--- a/locale/localeinfo.h
+++ b/locale/localeinfo.h
@@ -260,12 +260,15 @@ extern __thread struct __locale_data *const *_nl_current_##category \
  #define _NL_CURRENT_WORD(category, item) \
    ((uint32_t) (*_nl_current_##category)->values[_NL_ITEM_INDEX (item)].word)

-/* This is used in lc-CATEGORY.c to define _nl_current_CATEGORY.  */
+/* This is used in lc-CATEGORY.c to define _nl_current_CATEGORY. The symbol
+   _nl_current_CATEGORY_used is set to a value unequal to zero to mark this
+   category as used. On S390 the used relocation to load the symbol address
+   can only handle even addresses.  */

Ok, but two spaces after period.

Andreas.


Commited with the two spaces.

Thanks.
Stefan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]