This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] Update minimum make version to 3.81

From: Mike Frysinger <vapier at gentoo dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
Date: Fri, 24 Jun 2016 12:10:32 -0400
Subject: Re: [RFC] Update minimum make version to 3.81
Authentication-results: sourceware.org; auth=none
References: <9be74649-8a90-1023-df39-a319b6d85b74 at linux dot vnet dot ibm dot com> <20160610222744 dot B09AB2C39F7 at topped-with-meat dot com> <ec2d5c66-e492-3e4b-8783-d987d638b14b at redhat dot com>

On 24 Jun 2016 13:24, Florian Weimer wrote:
> On 06/11/2016 12:27 AM, Roland McGrath wrote:
> > eval is a pretty horrible feature and I'd probably object to introducing
> > any uses of it into libc's makefiles.  We already have lots of things that
> > might have been done that way, but are instead done with generated makefiles.
> 
> I would like to put this into malloc/Makefile:
> 
> $(foreach t,$(tests),$(eval CFLAGS-$t.c += -DTEST_NO_MALLOPT))
> 
> What's the alternative for adding a -D flag to every test compilation in 
> a subdirectory?

maybe something like (untested):
CPPFLAGS += $(if $(filter $(@F),$(tests)),-DTEST_NO_MALLOPT)
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [RFC] Update minimum make version to 3.81
  - From: Florian Weimer

References:
- [RFC] Update minimum make version to 3.81
  - From: Paul E. Murphy
- Re: [RFC] Update minimum make version to 3.81
  - From: Roland McGrath
- Re: [RFC] Update minimum make version to 3.81
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]