This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v8] Add pretty printers for the NPTL lock types


On Tue, Jun 21, 2016 at 06:22:27PM -0300, Martin Galvan wrote:
> Great, how would I go about doing this? That is, just exactly what
> should I write? I'm thinking of adding something like
> 
> old-link-rpath := link-libc-tests-rpath-link
> link-libc-tests-rpath-link = -Wl,-rpath=$(rpath-link)
> 
> at the beginning of pretty-printers/Makefile, and then
> 
> link-libc-tests-rpath-link = old-link-rpath
> 
> at the end.

I was actually thinking of something even simpler, like setting
build-hardcoded-path-in-tests in Makeconfig if the subdir is
pretty-printers.  You could over-engineer it by adding a new
test-need-hardcoded-path variable that each makefile sets and then
test that in Makeconfig, but I think we can leave that for when any
other subdir always needs a hardcoded path in tests.

> 
> In any case, how can I know gdb isn't loading the recently built
> libraries? info share shows the following for test-mutex-printer:
> 
> (gdb) info share
> From                To                  Syms Read   Shared Object Library
> 0x00007ffff7ddbad0  0x00007ffff7df5960  Yes
> /home/martin/glibc/install/lib/ld-linux-x86-64.so.2
>                                         No          linux-vdso.so.1
> 0x00007ffff7bc3a90  0x00007ffff7bd03f1  Yes
> /home/martin/glibc/install/lib/libpthread.so.0
> 0x00007ffff78489a0  0x00007ffff796ad53  Yes
> /home/martin/glibc/install/lib/libc.so.6
> 
> Looks to me like it's finding the built library alright.

I had checked /proc/PID/maps of the inferior.  I can run it again over
the weekend and check what 'info shared' says if you want, but if
there's a difference, I'd say gdb is wrong and not the proc file.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]