This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.


On Wed, 22 Jun 2016, Yury Norov wrote:

> > As well as preprocessor indentation, this is missing spaces after '('; 
> > check for and fix that issue throughout this patch series.  (There are 
> > only a few cases where a macro is used to construct a type / variable 
> > name, such as ElfW, where missing the space is more usual.)
> > 
> > -- 
> > Joseph S. Myers
> > joseph@codesourcery.com
> 
> So, you want have it like this?
> #ifdef __LP64__
> # define RTLD_START RTLD_START_1( "x", "3", "sp" )

Sorry, before '(' in function and function-like-macro calls, as in 
standard GNU style.

# define RTLD_START RTLD_START_1 ("x", "3", "sp")

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]