This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Yury Norov <ynorov at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <pinskia at gmail dot com>, Andrew Pinski <apinski at cavium dot com>
- Date: Wed, 22 Jun 2016 10:37:27 +0000
- Subject: Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.
- Authentication-results: sourceware.org; auth=none
- References: <1466485631-3532-1-git-send-email-ynorov at caviumnetworks dot com> <1466485631-3532-7-git-send-email-ynorov at caviumnetworks dot com> <alpine dot DEB dot 2 dot 20 dot 1606211027120 dot 4526 at digraph dot polyomino dot org dot uk> <20160622060227 dot GA22466 at yury-N73SV>
On Wed, 22 Jun 2016, Yury Norov wrote:
> > As well as preprocessor indentation, this is missing spaces after '(';
> > check for and fix that issue throughout this patch series. (There are
> > only a few cases where a macro is used to construct a type / variable
> > name, such as ElfW, where missing the space is more usual.)
> >
> > --
> > Joseph S. Myers
> > joseph@codesourcery.com
>
> So, you want have it like this?
> #ifdef __LP64__
> # define RTLD_START RTLD_START_1( "x", "3", "sp" )
Sorry, before '(' in function and function-like-macro calls, as in
standard GNU style.
# define RTLD_START RTLD_START_1 ("x", "3", "sp")
--
Joseph S. Myers
joseph@codesourcery.com