This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] test-skeleton: redirect stderr to stdout

From: "Dmitry V. Levin" <ldv at altlinux dot org>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: Zack Weinberg <zackw at panix dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 17 Jun 2016 17:56:46 +0300
Subject: Re: [PATCH] test-skeleton: redirect stderr to stdout
Authentication-results: sourceware.org; auth=none
References: <1466052483-27705-1-git-send-email-vapier at gentoo dot org> <CAKCAbMgz7bkPxyRgxvgqSbHPpqo-irqKwq0wVYPL6z+-6NGzkA at mail dot gmail dot com> <20160616150706 dot GI4053 at vapier dot lan>

On Thu, Jun 16, 2016 at 11:07:06AM -0400, Mike Frysinger wrote:
> On 16 Jun 2016 08:50, Zack Weinberg wrote:
> > On Thu, Jun 16, 2016 at 12:48 AM, Mike Frysinger wrote:
> > > +  fclose (stderr);
> > > +  dup2 (STDOUT_FILENO, STDERR_FILENO);
> > > +  stderr = fdopen (STDERR_FILENO, "w");
> > 
> > Wouldn't the dup2 be sufficient by itself?  And then you don't have to
> > worry about allocation failure in fdopen.
> 
> i don't think there's any guarantee of the stdio handles being sane when
> the fd is changed underneath them.  if the standards say otherwise, or
> we have a guarantee in glibc, then sure.

The file behind fd might change but fd remains the same.
What kind of stdio insanity are you trying to avoid?


-- 
ldv

Attachment: pgpku8Cdpr3Rv.pgp
Description: PGP signature

References:
- [PATCH] test-skeleton: redirect stderr to stdout
  - From: Mike Frysinger
- Re: [PATCH] test-skeleton: redirect stderr to stdout
  - From: Zack Weinberg
- Re: [PATCH] test-skeleton: redirect stderr to stdout
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]