This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Export stack_used as __stack_used

From: Florian Weimer <fweimer at redhat dot com>
To: Gary Benson <gbenson at redhat dot com>
Cc: libc-alpha at sourceware dot org, Pedro Alves <palves at redhat dot com>
Date: Fri, 17 Jun 2016 14:33:41 +0200
Subject: Re: [PATCH] Export stack_used as __stack_used
Authentication-results: sourceware.org; auth=none
References: <20160613112351 dot GA655 at blade dot nx> <1466163476-10459-1-git-send-email-gbenson at redhat dot com>

On 06/17/2016 01:37 PM, Gary Benson wrote:

Hi all,

This commit renames "stack_used" as "__stack_used" and changes it from
a static variable in allocatestack.c to an internally exported symbol
available to all nptl source files.  This fixes bug 17629 (and thus
GDB PR 9635).

What do you mean by “export”? The __ prefix suggests that you want toexport it as a symbol (probably GLIBC_PRIVATE), but I think you'd needto update nptl/Versions in this case.

If the variable remains nptl-internal, I expect that you could turn itinto a hidden symbol, and keep its current name.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH] Export stack_used as __stack_used
  - From: Gary Benson

References:
- Re: [RFC v2][PATCH 22/27] Export stack_used as __stack_used
  - From: Gary Benson
- [PATCH] Export stack_used as __stack_used
  - From: Gary Benson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]