This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] _nss_nis_initgroups_dyn: Return error status
- From: Andreas Schwab <schwab at suse dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 16 Jun 2016 11:31:13 +0200
- Subject: Re: [PATCH] _nss_nis_initgroups_dyn: Return error status
- Authentication-results: sourceware.org; auth=none
- References: <54EF320A dot 90409 at redhat dot com>
Florian Weimer <fweimer@redhat.com> writes:
> This seems to have been an oversight. An error can be returned if the
> function is left with âgoto done;â.
>
> 2015-02-26 Florian Weimer <fweimer@redhat.com>
>
> * nis/nss_nis/nis-initgroups.c (_nss_nis_initgroups_dyn):
> Return error status.
>
> diff --git a/nis/nss_nis/nis-initgroups.c b/nis/nss_nis/nis-initgroups.c
> index d22b241..ed5c26b 100644
> --- a/nis/nss_nis/nis-initgroups.c
> +++ b/nis/nss_nis/nis-initgroups.c
> @@ -326,5 +326,5 @@ done:
> free (intern.next);
> }
>
> - return NSS_STATUS_SUCCESS;
> + return status;
> }
This causes _nss_nis_initgroups_dyn to always return
NSS_STATUS_NOTFOUND.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."