This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Consolidate preadv/preadv64 implementation
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 2 Jun 2016 14:34:13 -0300
- Subject: Re: [PATCH 1/2] Consolidate preadv/preadv64 implementation
- Authentication-results: sourceware.org; auth=none
- References: <1464866792-11025-1-git-send-email-adhemerval dot zanella at linaro dot org> <20160602172609 dot GS7717 at vapier dot lan>
On 02/06/2016 14:26, Mike Frysinger wrote:
> On 02 Jun 2016 08:26, Adhemerval Zanella wrote:
>> --- a/sysdeps/unix/sysv/linux/preadv64.c
>> +++ b/sysdeps/unix/sysv/linux/preadv64.c
>>
>> +#ifndef __NR_preadv64
>> +# define __NR_preadv64 __NR_preadv
>> +#endif
>> +
>> +#ifdef __ASSUME_PREADV
>> +ssize_t
>> +preadv64 (int fd, const struct iovec *vector, int count, off64_t offset)
>> +{
>> + return SYSCALL_CANCEL (preadv64, fd, vector, count,
>> + __ALIGNMENT_ARG SYSCALL_LL64 (offset));
>> +}
>> +#else
>> +static ssize_t __atomic_preadv_replacement (int, const struct iovec *,
>> + int, off_t) internal_function;
>> +ssize_t
>> +preadv64 (int fd, const struct iovec *vector, int count, off64_t offset)
>> +{
>> +#ifdef __NR_preadv64
>
> seems like __NR_preadv64 is always defined now ?
> -mike
>
Indeed, I overlook it. I think maybe using another define set in first
__NR_preadv64 check (#define USE_SYSCALL or something). I will change it.