This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH x86-64][BZ #20024] Fixed vector sincos/sincosf ABI
- From: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 1 Jun 2016 23:03:19 +0300
- Subject: Re: [PATCH x86-64][BZ #20024] Fixed vector sincos/sincosf ABI
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3tO0RGFjbrQaEV80rTCWmUy8LQjkZ7gRd9j+Q3YQ2+nAQ at mail dot gmail dot com> <574E28FB dot 4000803 at redhat dot com>
2016-06-01 3:14 GMT+03:00 Carlos O'Donell <carlos@redhat.com>:
> On 05/31/2016 03:25 PM, Andrew Senkevich wrote:
>> Hi,
>>
>> this patch fixes wrong vector sincos/sincosf ABI to have it compatible with
>> current vector function declaration. According to current vector function
>> declaration vectorized sincos should have vector of pointers for second and
>> third parameters, so it is fixed with implementation as wrapper to version
>> having second and third parameters as pointers.
>> Is it Ok for trunk, 2.22 and 2.23 releases branches?
>
> How did you test this? Is it possible to add a regression test that detects
> this issue?
I tested with testcase from the bug. But for AVX512 variants needed
GCC not less than 6.1.
Is it Ok to add regression tests with assembly sources (or at least
for that vector versions for which can be hard to get vectorized
testcase with any GCC version)?
--
WBR,
Andrew