This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ #19654] Added tests for *_finite aliases from libmvec
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 17 May 2016 23:06:49 +0000
- Subject: Re: [PATCH] [BZ #19654] Added tests for *_finite aliases from libmvec
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3uz=Xi0Ogj0MYrCgDque_dtRaXTiX2dX3dSua42-Pgs=Q at mail dot gmail dot com>
On Sat, 20 Feb 2016, Andrew Senkevich wrote:
> + if (log_res[0] != 0.0) abort ();
> + if (exp_res[0] != 1.0) abort ();
> + if (pow_res[0] != 1.0) abort ();
Aborting is not the right way for a test to report an error. Rather, the
function should return an error status to its caller (ending up with
do_test returning 1 on error, 0 on success - and ideally 77 for
UNSUPPORTED tests, which would be those where CHECK_ARCH_EXT fails).
--
Joseph S. Myers
joseph@codesourcery.com