This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 2/2] powerpc: Fix operand prefixes


Thank you.

Pushed as eb3b8a4924502e508d5b353ed75f39826d2c9466.

On Tue, 03 May 2016 11:24:45 -0300
"Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com> wrote:

> "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com> writes:
> 
> > The file sysdeps/powerpc/sysdeps.h defines aliases for condition register
> > operands.  E.g.: 'cr7' means condition register 7.  On the one hand, this
> > increases readability, as it makes it easier for readers to know whether the
> > operand is a condition register, a general purpose register or an immediate.
> > On the other hand, this permits that condition registers be written as if they
> > were general purpose, and vice-versa, thus reducing the readability of the
> > code.
> >
> > This commit removes some of these unintentional misuses.
> >
> > The changes have no effect on the final code.  Checked with objdump.
> >
> > 2016-04-18  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>
> >
> > 	* sysdeps/powerpc/powerpc64/power8/strncpy.S: Fix use of condition
> > 	registers specifiers where general purpose registers specifiers should
> > 	have been used.  
> 
> LGTM.
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]