This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] hesiod_end: Do not call res_nclose(&_res) [BZ #19573]

From: Florian Weimer <fweimer at redhat dot com>
To: Anders Kaseorg <andersk at mit dot edu>
Cc: libc-alpha at sourceware dot org
Date: Mon, 2 May 2016 12:02:08 +0200
Subject: Re: [PATCH] hesiod_end: Do not call res_nclose(&_res) [BZ #19573]
Authentication-results: sourceware.org; auth=none
References: <alpine dot DEB dot 2 dot 10 dot 1604221400580 dot 60537 at buzzword-bingo dot mit dot edu> <87eg9wjynn dot fsf at mid dot deneb dot enyo dot de> <alpine dot DEB dot 2 dot 10 dot 1604231408240 dot 60537 at buzzword-bingo dot mit dot edu> <alpine dot DEB dot 2 dot 10 dot 1604271134490 dot 60537 at buzzword-bingo dot mit dot edu> <572102BC dot 8050906 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1604301914310 dot 48504 at buzzword-bingo dot mit dot edu>

On 05/01/2016 01:17 AM, Anders Kaseorg wrote:

On Wed, 27 Apr 2016, Florian Weimer wrote:

On 04/27/2016 05:36 PM, Anders Kaseorg wrote:

Is this ready to be committed, or do you still have concerns?


Yes please, this change looks fine.


Do I need to do anything else?  In case it wasnât clear, I donât have
commit access.


I wasn't aware of that, sorry.

I have looked at the patch again, and I think it is technicallyincorrect. The proper way to fix this would be to install a resolvercallback which does nothing, and free the resolver state only if thereis *no* callback (because we know we own it).

But we only ever use the thread-local resolver state anyway, so I'm justgoing to remove this code.


Florian

Follow-Ups:
- Re: [PATCH] hesiod_end: Do not call res_nclose(&_res) [BZ #19573]
  - From: Anders Kaseorg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]