This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/17 v6] Configury support for --enable-stack-protector.
- From: Nix <nix at esperi dot org dot uk>
- To: libc-alpha at sourceware dot org
- Date: Sun, 10 Apr 2016 12:26:00 +0100
- Subject: Re: [PATCH 01/17 v6] Configury support for --enable-stack-protector.
- Authentication-results: sourceware.org; auth=none
- References: <1457882222-22599-1-git-send-email-nix at esperi dot org dot uk> <1457882222-22599-2-git-send-email-nix at esperi dot org dot uk> <20160410035822 dot GM6588 at vapier dot lan>
On 10 Apr 2016, Mike Frysinger uttered the following:
> On 13 Mar 2016 15:16, Nix wrote:
>> +case "$enable_stack_protector" in
>> +all|yes|no|strong) ;;
>> +*) AC_MSG_ERROR([Not a valid argument for --enable-stack-protector]);;
>
> should include the value of the var here for clarity
I'm not entirely clear how you do that. You can't use
$enable_stack_protector itself in there, because the Autoconf quoting
will get in the way, won't it?
>> +if test "$libc_cv_ssp" = yes; then
>> + no_stack_protector=-fno-stack-protector
>
> quote it
Will do :)
--
NULL && (void)