This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]
- From: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 5 Apr 2016 17:05:00 +0200
- Subject: Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]
- Authentication-results: sourceware.org; auth=none
- References: <56CF62D0 dot 8060803 at redhat dot com> <56CF7D30 dot 2090000 at redhat dot com> <56DD80AF dot 3000408 at redhat dot com> <56DD9E1C dot 5030408 at redhat dot com> <56DDA516 dot 4090509 at redhat dot com> <56DDB33A dot 1000405 at redhat dot com> <56DDDF0D dot 8040601 at redhat dot com> <56FBBDE3 dot 2050106 at redhat dot com> <56FBEBED dot 6050206 at gmail dot com> <57027826 dot 4000308 at redhat dot com> <ne03t8$nla$1 at ger dot gmane dot org> <mvm37r01ap3 dot fsf at hawking dot suse dot de>
On 04/05/2016 02:50 PM, Andreas Schwab wrote:
Stefan Liebler <stli@linux.vnet.ibm.com> writes:
diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
index baada9e..fb2a763 100644
--- a/stdio-common/printf_fp.c
+++ b/stdio-common/printf_fp.c
@@ -1248,8 +1248,8 @@ ___printf_fp_l (FILE *fp, locale_t loc,
}
return done;
}
-ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
-ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
+libc_hidden_def (__printf_fp_l)
+strong_alias (___printf_fp_l, __printf_fp_l)
Please rename ___printf_fp_l to __printf_fp_l, no need for the alias.
Otherwise looks ok.
Andreas.
Here is an updated patch to reflect the mentioned changes.
Okay to commit?
ChangeLog:
2016-04-05 Stefan Liebler <stli@linux.vnet.ibm.com>
* stdio-common/printf_fp.c (__printf_fp_l):
Rename ___printf_fp_l to __printf_fp_l and
remove strong alias. Use libc_hidden_def instead
of ldbl_hidden_def macro.
diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
index baada9e..fdfe06b 100644
--- a/stdio-common/printf_fp.c
+++ b/stdio-common/printf_fp.c
@@ -209,9 +209,9 @@ hack_digit (struct hack_digit_param *p)
}
int
-___printf_fp_l (FILE *fp, locale_t loc,
- const struct printf_info *info,
- const void *const *args)
+__printf_fp_l (FILE *fp, locale_t loc,
+ const struct printf_info *info,
+ const void *const *args)
{
/* The floating-point value to output. */
union
@@ -1248,14 +1248,13 @@ ___printf_fp_l (FILE *fp, locale_t loc,
}
return done;
}
-ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
-ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
+libc_hidden_def (__printf_fp_l)
int
___printf_fp (FILE *fp, const struct printf_info *info,
const void *const *args)
{
- return ___printf_fp_l (fp, _NL_CURRENT_LOCALE, info, args);
+ return __printf_fp_l (fp, _NL_CURRENT_LOCALE, info, args);
}
ldbl_hidden_def (___printf_fp, __printf_fp)
ldbl_strong_alias (___printf_fp, __printf_fp)