This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4] Remove powerpc64 strspn, strcspn, and strpbrk implementation
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Cc:
- Date: Wed, 30 Mar 2016 15:14:31 -0300
- Subject: Re: [PATCH 4/4] Remove powerpc64 strspn, strcspn, and strpbrk implementation
- Authentication-results: sourceware.org; auth=none
- References: <1459178389-14133-1-git-send-email-adhemerval dot zanella at linaro dot org> <1459178389-14133-5-git-send-email-adhemerval dot zanella at linaro dot org> <87r3es9kgb dot fsf at totoro dot br dot ibm dot com> <56FC07A1 dot 5010102 at linaro dot org>
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> On 30-03-2016 10:14, Tulio Magno Quites Machado Filho wrote:
>> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>>
>>> * sysdeps/powerpc/powerpc64/strcspn.S: Remove file.
>>> * sysdeps/powerpc/powerpc64/strpbrk.S: Likewise.
>>
>> But the removal of these 2 brings some serious performance degradation.
>> I think we should keep them for now.
>
> Do you mean regression on POWER7 only or for POWER8 as well?
Both.
> And what do you mean by 'serious'?
The new strcspn C implementation spent 8x the time of the powerpc64 assembly.
While strpbrk spent ~12x the time.
Using the benchtests.
--
Tulio Magno