This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4] Remove powerpc64 strspn, strcspn, and strpbrk implementation
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Cc:
- Date: Wed, 30 Mar 2016 10:14:28 -0300
- Subject: Re: [PATCH 4/4] Remove powerpc64 strspn, strcspn, and strpbrk implementation
- Authentication-results: sourceware.org; auth=none
- References: <1459178389-14133-1-git-send-email-adhemerval dot zanella at linaro dot org> <1459178389-14133-5-git-send-email-adhemerval dot zanella at linaro dot org>
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> This patch removes the powerpc64 optimized strspn, strcspn, and
> strpbrk assembly implementation now that the default C one
> implements the same strategy. On internal glibc benchtests
> current implementations shows similar performance with -O2.
>
> Tested on powerpc64le (POWER8).
>
> * sysdeps/powerpc/powerpc64/strspn.S: Likewise.
I tested this on POWER7 as well. Although it isn't as good as in POWER8,
it's competitive. I agree to remove it.
> * sysdeps/powerpc/powerpc64/strcspn.S: Remove file.
> * sysdeps/powerpc/powerpc64/strpbrk.S: Likewise.
But the removal of these 2 brings some serious performance degradation.
I think we should keep them for now.
--
Tulio Magno