This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] mips: terminate the FDE before the return trampoline in makecontext
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: Aurelien Jarno <aurelien at aurel32 dot net>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 22 Mar 2016 21:01:31 +0000
- Subject: Re: [PATCH] mips: terminate the FDE before the return trampoline in makecontext
- Authentication-results: sourceware.org; auth=none
- References: <1457509993-2393-1-git-send-email-aurelien at aurel32 dot net>
On Wed, 9 Mar 2016, Aurelien Jarno wrote:
> diff --git a/sysdeps/unix/sysv/linux/mips/makecontext.S b/sysdeps/unix/sysv/linux/mips/makecontext.S
> index 66600c7..3196554 100644
> --- a/sysdeps/unix/sysv/linux/mips/makecontext.S
> +++ b/sysdeps/unix/sysv/linux/mips/makecontext.S
> @@ -153,6 +153,11 @@ NESTED (__makecontext, FRAMESZ, ra)
> #endif
> jr ra
>
> + /* We need to terminate the FDE to stop unwinding if backtrace was
> + called within a context created by makecontext. */
> + cfi_endproc
> + nop
> +
> 99:
What's this NOP needed for here?
Maciej